-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a coroutine AV crash #16412
Fix a coroutine AV crash #16412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a horrible implementation detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be shocked if this was the only file with this pattern in it. Maybe we need to broadly do a sweep of "event callback lambda's considered harmful"
I did try to find other instances of lambdas-that-are-coroutines but couldn't. I believe these were the only ones, thankfully! |
tl;dr: A coroutine lambda does not hold onto captured variables. This causes an AV crash when closing tabs. I randomly noticed this in a Debug build as the memory contents got replaced with 0xCD. In a Release build this bug is probably fairly subtle and not common. (cherry picked from commit 91fd7d0) Service-Card-Id: 91258717 Service-Version: 1.19
tl;dr: A coroutine lambda does not hold onto captured variables. This causes an AV crash when closing tabs. I randomly noticed this in a Debug build as the memory contents got replaced with 0xCD. In a Release build this bug is probably fairly subtle and not common. (cherry picked from commit 91fd7d0) Service-Card-Id: 91258716 Service-Version: 1.18
tl;dr: A coroutine lambda does not hold onto captured variables.
This causes an AV crash when closing tabs. I randomly noticed this
in a Debug build as the memory contents got replaced with 0xCD.
In a Release build this bug is probably fairly subtle and not common.